From eda1599c0d47645aa60a06199a03a79f5d7ae0ef Mon Sep 17 00:00:00 2001
From: Aaryan Khandelwal <65252264+aaryan610@users.noreply.github.com>
Date: Wed, 26 Jun 2024 18:49:13 +0530
Subject: [PATCH] chore: add extra check to fetch pages list and page details
 (#4945)

---
 .../(detail)/[projectId]/pages/(detail)/[pageId]/page.tsx   | 6 ++++--
 web/core/components/pages/pages-list-view.tsx               | 4 ++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/[pageId]/page.tsx b/web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/[pageId]/page.tsx
index cbd500273..8c96f2bcf 100644
--- a/web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/[pageId]/page.tsx
+++ b/web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/[pageId]/page.tsx
@@ -26,8 +26,10 @@ const PageDetailsPage = observer(() => {
 
   // fetch page details
   const { error: pageDetailsError } = useSWR(
-    pageId ? `PAGE_DETAILS_${pageId}` : null,
-    pageId ? () => getPageById(workspaceSlug?.toString(), projectId?.toString(), pageId.toString()) : null,
+    workspaceSlug && projectId && pageId ? `PAGE_DETAILS_${pageId}` : null,
+    workspaceSlug && projectId && pageId
+      ? () => getPageById(workspaceSlug?.toString(), projectId?.toString(), pageId.toString())
+      : null,
     {
       revalidateIfStale: false,
       revalidateOnFocus: false,
diff --git a/web/core/components/pages/pages-list-view.tsx b/web/core/components/pages/pages-list-view.tsx
index abcd06298..7b106a458 100644
--- a/web/core/components/pages/pages-list-view.tsx
+++ b/web/core/components/pages/pages-list-view.tsx
@@ -19,8 +19,8 @@ export const PagesListView: React.FC<TPageView> = observer((props) => {
   const { isAnyPageAvailable, getAllPages } = useProjectPages();
   // fetching pages list
   useSWR(
-    projectId ? `PROJECT_PAGES_${projectId}` : null,
-    projectId ? () => getAllPages(workspaceSlug, projectId, pageType) : null
+    workspaceSlug && projectId && pageType ? `PROJECT_PAGES_${projectId}` : null,
+    workspaceSlug && projectId && pageType ? () => getAllPages(workspaceSlug, projectId, pageType) : null
   );
 
   // pages loader