binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[WEB-5454] fix: optimize date validation logic in CycleCreateUpdateModal #8394

Browse source
This commit is contained in:
Jayash Tripathy 2025-12-19 15:41:21 +05:30 • committed by GitHub
parent 1e3514575f
commit f3d5e7def3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
apps/web/core/components/cycles/modal.tsx
View file

@ -136,14 +136,20 @@ export function CycleCreateUpdateModal(props: CycleModalProps) {
if (payload.start_date && payload.end_date) { if (payload.start_date && payload.end_date) {
if (data?.id) { if (data?.id) {
// Update existing cycle - always include cycle_id for validation // Update existing cycle - only check dates if they've changed
const originalStartDate = renderFormattedPayloadDate(data.start_date) ?? null;
const originalEndDate = renderFormattedPayloadDate(data.end_date) ?? null;
const hasDateChanged = payload.start_date !== originalStartDate || payload.end_date !== originalEndDate;
if (hasDateChanged) {
isDateValid = await dateChecker(projectId, { isDateValid = await dateChecker(projectId, {
start_date: payload.start_date, start_date: payload.start_date,
end_date: payload.end_date, end_date: payload.end_date,
cycle_id: data.id, cycle_id: data.id,
}); });
}
} else { } else {
// Create new cycle - no cycle_id needed // Create new cycle - always check dates
isDateValid = await dateChecker(projectId, { isDateValid = await dateChecker(projectId, {
start_date: payload.start_date, start_date: payload.start_date,
end_date: payload.end_date, end_date: payload.end_date,