binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix: project settings pages permissions (#6649)

Browse source 
* fix: Handled workspace switcher closing on click

* fix: permissions for labels dnd + issue state creation
This commit is contained in:
Akshita Goyal 2025-02-19 18:05:43 +05:30 • committed by GitHub
parent 3de655cbd4
commit f6dfca4fdc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 13 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
web/core/components/labels/label-drag-n-drop-HOC.tsx
View file

@ -9,10 +9,12 @@ import { attachInstruction } from "@atlaskit/pragmatic-drag-and-drop-hitbox/tree
import { observer } from "mobx-react";
import { createRoot } from "react-dom/client";
// types
import { EUserPermissions, EUserPermissionsLevel } from "@plane/constants";
import { IIssueLabel, InstructionType } from "@plane/types";
// ui
import { DropIndicator } from "@plane/ui";
// components
import { useUserPermissions } from "@/hooks/store";
import { LabelName } from "./label-block/label-name";
import { TargetData, getCanDrop, getInstructionFromPayload } from "./label-utils";
@ -58,11 +60,14 @@ export const LabelDndHOC = observer((props: Props) => {
const labelRef = useRef<HTMLDivElement | null>(null);
const dragHandleRef = useRef<HTMLButtonElement | null>(null);
const { allowPermissions } = useUserPermissions();
const isEditable = allowPermissions([EUserPermissions.ADMIN], EUserPermissionsLevel.PROJECT);
useEffect(() => {
const element = labelRef.current;
const dragHandleElement = dragHandleRef.current;
if (!element) return;
if (!element || !isEditable) return;
return combine(
draggable({

10
web/core/components/project-states/group-item.tsx
View file

@ -75,12 +75,16 @@ export const GroupItem: FC<TGroupItem> = observer((props) => {
</div>
<div className="text-base font-medium text-custom-text-200 capitalize px-1">{groupKey}</div>
</div>
<div
className="flex-shrink-0 w-6 h-6 rounded flex justify-center items-center overflow-hidden transition-colors hover:bg-custom-background-80 cursor-pointer text-custom-primary-100/80 hover:text-custom-primary-100"
<button
className={cn(
"flex-shrink-0 w-6 h-6 rounded flex justify-center items-center overflow-hidden transition-colors hover:bg-custom-background-80 cursor-pointer text-custom-primary-100/80 hover:text-custom-primary-100",
!isEditable && "cursor-not-allowed text-custom-text-400 hover:text-custom-text-400"
)}
onClick={() => !createState && setCreateState(true)}
disabled={!isEditable}
>
<Plus className="w-4 h-4" />
</div>
</button>
</div>
{shouldShowEmptyState && (