binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[WEB-3589] improvement: reset language to default on sign out (#6775)

Browse source
This commit is contained in:
Prateek Shourya 2025-03-19 14:42:19 +05:30 • committed by GitHub
parent 3f22642732
commit f82d4a9ead
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 9 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/i18n/src/constants/language.ts
View file

@ -19,4 +19,4 @@ export const SUPPORTED_LANGUAGES: ILanguageOption[] = [
{ label: "한국어", value: "ko" }, { label: "한국어", value: "ko" },
]; ];
export const STORAGE_KEY = "userLanguage"; export const LANGUAGE_STORAGE_KEY = "userLanguage";

44
packages/i18n/src/store/index.ts
View file

@ -3,7 +3,7 @@ import get from "lodash/get";
import merge from "lodash/merge"; import merge from "lodash/merge";
import { makeAutoObservable, runInAction } from "mobx"; import { makeAutoObservable, runInAction } from "mobx";
// constants // constants
import { FALLBACK_LANGUAGE, SUPPORTED_LANGUAGES, STORAGE_KEY } from "../constants"; import { FALLBACK_LANGUAGE, SUPPORTED_LANGUAGES, LANGUAGE_STORAGE_KEY } from "../constants";
// core translations imports // core translations imports
import coreEn from "../locales/en/core.json"; import coreEn from "../locales/en/core.json";
// types // types
@ -48,14 +48,14 @@ export class TranslationStore {
private initializeLanguage() { private initializeLanguage() {
if (typeof window === "undefined") return; if (typeof window === "undefined") return;
const savedLocale = localStorage.getItem(STORAGE_KEY) as TLanguage; const savedLocale = localStorage.getItem(LANGUAGE_STORAGE_KEY) as TLanguage;
if (this.isValidLanguage(savedLocale)) { if (this.isValidLanguage(savedLocale)) {
this.setLanguage(savedLocale); this.setLanguage(savedLocale);
return; return;
} }
const browserLang = this.getBrowserLanguage(); // Fallback to default language
this.setLanguage(browserLang); this.setLanguage(FALLBACK_LANGUAGE);
} }
/** Loads the translations for the current language */ /** Loads the translations for the current language */
@ -175,40 +175,6 @@ export class TranslationStore {
return lang !== null && this.availableLanguages.some((l) => l.value === lang); return lang !== null && this.availableLanguages.some((l) => l.value === lang);
} }
/** Checks if a language code is similar to any supported language */
private findSimilarLanguage(lang: string): TLanguage | null {
// Convert to lowercase for case-insensitive comparison
const normalizedLang = lang.toLowerCase();
// Find a supported language that includes or is included in the browser language
const similarLang = this.availableLanguages.find(
(l) => normalizedLang.includes(l.value.toLowerCase()) || l.value.toLowerCase().includes(normalizedLang)
);
return similarLang ? similarLang.value : null;
}
/** Gets the browser language based on the navigator.language */
private getBrowserLanguage(): TLanguage {
const browserLang = navigator.language;
// Check exact match first
if (this.isValidLanguage(browserLang)) {
return browserLang;
}
// Check base language without region code
const baseLang = browserLang.split("-")[0];
if (this.isValidLanguage(baseLang)) {
return baseLang as TLanguage;
}
// Try to find a similar language
const similarLang = this.findSimilarLanguage(browserLang) || this.findSimilarLanguage(baseLang);
return similarLang || FALLBACK_LANGUAGE;
}
/** /**
* Gets the cache key for the given key and locale * Gets the cache key for the given key and locale
* @param key - the key to get the cache key for * @param key - the key to get the cache key for
@ -293,7 +259,7 @@ export class TranslationStore {
} }
if (typeof window !== "undefined") { if (typeof window !== "undefined") {
localStorage.setItem(STORAGE_KEY, lng); localStorage.setItem(LANGUAGE_STORAGE_KEY, lng);
document.documentElement.lang = lng; document.documentElement.lang = lng;
} }

4
web/core/store/root.store.ts
View file

@ -1,4 +1,6 @@
import { enableStaticRendering } from "mobx-react"; import { enableStaticRendering } from "mobx-react";
// plane imports
import { FALLBACK_LANGUAGE, LANGUAGE_STORAGE_KEY } from "@plane/i18n";
// plane web store // plane web store
import { CommandPaletteStore, ICommandPaletteStore } from "@/plane-web/store/command-palette.store"; import { CommandPaletteStore, ICommandPaletteStore } from "@/plane-web/store/command-palette.store";
import { RootStore } from "@/plane-web/store/root.store"; import { RootStore } from "@/plane-web/store/root.store";
@ -97,7 +99,7 @@ export class CoreRootStore {
resetOnSignOut() { resetOnSignOut() {
// handling the system theme when user logged out from the app // handling the system theme when user logged out from the app
localStorage.setItem("theme", "system"); localStorage.setItem("theme", "system");
localStorage.setItem(LANGUAGE_STORAGE_KEY, FALLBACK_LANGUAGE);
this.router = new RouterStore(); this.router = new RouterStore();
this.commandPalette = new CommandPaletteStore(); this.commandPalette = new CommandPaletteStore();
this.instance = new InstanceStore(); this.instance = new InstanceStore();