* added PageBinaryUpdateSerializer for binary data validation and update * chore: added validation for description * chore: removed the duplicated file * Fixed coderabbit comments - Improve content validation by consolidating patterns and enhancing recursion checks - Updated `PageBinaryUpdateSerializer` to simplify assignment of validated data. - Enhanced `content_validator.py` with consolidated dangerous patterns and added recursion depth checks to prevent stack overflow during validation. - Improved readability and maintainability of validation functions by using constants for patterns. --------- Co-authored-by: Dheeraj Kumar Ketireddy <dheeru0198@gmail.com>
344 lines
10 KiB
Python
344 lines
10 KiB
Python
# Third party imports
|
|
from rest_framework import serializers
|
|
|
|
# Module imports
|
|
from .base import BaseSerializer, DynamicBaseSerializer
|
|
from .user import UserLiteSerializer, UserAdminLiteSerializer
|
|
|
|
|
|
from plane.db.models import (
|
|
Workspace,
|
|
WorkspaceMember,
|
|
WorkspaceMemberInvite,
|
|
WorkspaceTheme,
|
|
WorkspaceUserProperties,
|
|
WorkspaceUserLink,
|
|
UserRecentVisit,
|
|
Issue,
|
|
Page,
|
|
Project,
|
|
ProjectMember,
|
|
WorkspaceHomePreference,
|
|
Sticky,
|
|
WorkspaceUserPreference,
|
|
)
|
|
from plane.utils.constants import RESTRICTED_WORKSPACE_SLUGS
|
|
from plane.utils.url import contains_url
|
|
from plane.utils.content_validator import (
|
|
validate_html_content,
|
|
validate_json_content,
|
|
validate_binary_data,
|
|
)
|
|
|
|
# Django imports
|
|
from django.core.validators import URLValidator
|
|
from django.core.exceptions import ValidationError
|
|
import re
|
|
|
|
|
|
class WorkSpaceSerializer(DynamicBaseSerializer):
|
|
total_members = serializers.IntegerField(read_only=True)
|
|
logo_url = serializers.CharField(read_only=True)
|
|
role = serializers.IntegerField(read_only=True)
|
|
|
|
def validate_name(self, value):
|
|
# Check if the name contains a URL
|
|
if contains_url(value):
|
|
raise serializers.ValidationError("Name must not contain URLs")
|
|
return value
|
|
|
|
def validate_slug(self, value):
|
|
# Check if the slug is restricted
|
|
if value in RESTRICTED_WORKSPACE_SLUGS:
|
|
raise serializers.ValidationError("Slug is not valid")
|
|
# Slug should only contain alphanumeric characters, hyphens, and underscores
|
|
if not re.match(r"^[a-zA-Z0-9_-]+$", value):
|
|
raise serializers.ValidationError(
|
|
"Slug can only contain letters, numbers, hyphens (-), and underscores (_)"
|
|
)
|
|
return value
|
|
|
|
class Meta:
|
|
model = Workspace
|
|
fields = "__all__"
|
|
read_only_fields = [
|
|
"id",
|
|
"created_by",
|
|
"updated_by",
|
|
"created_at",
|
|
"updated_at",
|
|
"owner",
|
|
"logo_url",
|
|
]
|
|
|
|
|
|
class WorkspaceLiteSerializer(BaseSerializer):
|
|
class Meta:
|
|
model = Workspace
|
|
fields = ["name", "slug", "id", "logo_url"]
|
|
read_only_fields = fields
|
|
|
|
|
|
class WorkSpaceMemberSerializer(DynamicBaseSerializer):
|
|
member = UserLiteSerializer(read_only=True)
|
|
|
|
class Meta:
|
|
model = WorkspaceMember
|
|
fields = "__all__"
|
|
|
|
|
|
class WorkspaceMemberMeSerializer(BaseSerializer):
|
|
draft_issue_count = serializers.IntegerField(read_only=True)
|
|
|
|
class Meta:
|
|
model = WorkspaceMember
|
|
fields = "__all__"
|
|
|
|
|
|
class WorkspaceMemberAdminSerializer(DynamicBaseSerializer):
|
|
member = UserAdminLiteSerializer(read_only=True)
|
|
|
|
class Meta:
|
|
model = WorkspaceMember
|
|
fields = "__all__"
|
|
|
|
|
|
class WorkSpaceMemberInviteSerializer(BaseSerializer):
|
|
workspace = WorkspaceLiteSerializer(read_only=True)
|
|
invite_link = serializers.SerializerMethodField()
|
|
|
|
def get_invite_link(self, obj):
|
|
return f"/workspace-invitations/?invitation_id={obj.id}&email={obj.email}&slug={obj.workspace.slug}"
|
|
|
|
class Meta:
|
|
model = WorkspaceMemberInvite
|
|
fields = "__all__"
|
|
read_only_fields = [
|
|
"id",
|
|
"email",
|
|
"token",
|
|
"workspace",
|
|
"message",
|
|
"responded_at",
|
|
"created_at",
|
|
"updated_at",
|
|
"invite_link",
|
|
]
|
|
|
|
|
|
class WorkspaceThemeSerializer(BaseSerializer):
|
|
class Meta:
|
|
model = WorkspaceTheme
|
|
fields = "__all__"
|
|
read_only_fields = ["workspace", "actor"]
|
|
|
|
|
|
class WorkspaceUserPropertiesSerializer(BaseSerializer):
|
|
class Meta:
|
|
model = WorkspaceUserProperties
|
|
fields = "__all__"
|
|
read_only_fields = ["workspace", "user"]
|
|
|
|
|
|
class WorkspaceUserLinkSerializer(BaseSerializer):
|
|
class Meta:
|
|
model = WorkspaceUserLink
|
|
fields = "__all__"
|
|
read_only_fields = ["workspace", "owner"]
|
|
|
|
def to_internal_value(self, data):
|
|
url = data.get("url", "")
|
|
if url and not url.startswith(("http://", "https://")):
|
|
data["url"] = "http://" + url
|
|
|
|
return super().to_internal_value(data)
|
|
|
|
def validate_url(self, value):
|
|
url_validator = URLValidator()
|
|
try:
|
|
url_validator(value)
|
|
except ValidationError:
|
|
raise serializers.ValidationError({"error": "Invalid URL format."})
|
|
|
|
return value
|
|
|
|
def create(self, validated_data):
|
|
# Filtering the WorkspaceUserLink with the given url to check if the link already exists.
|
|
|
|
url = validated_data.get("url")
|
|
|
|
workspace_user_link = WorkspaceUserLink.objects.filter(
|
|
url=url,
|
|
workspace_id=validated_data.get("workspace_id"),
|
|
owner_id=validated_data.get("owner_id"),
|
|
)
|
|
|
|
if workspace_user_link.exists():
|
|
raise serializers.ValidationError(
|
|
{"error": "URL already exists for this workspace and owner"}
|
|
)
|
|
|
|
return super().create(validated_data)
|
|
|
|
def update(self, instance, validated_data):
|
|
# Filtering the WorkspaceUserLink with the given url to check if the link already exists.
|
|
|
|
url = validated_data.get("url")
|
|
|
|
workspace_user_link = WorkspaceUserLink.objects.filter(
|
|
url=url, workspace_id=instance.workspace_id, owner=instance.owner
|
|
)
|
|
|
|
if workspace_user_link.exclude(pk=instance.id).exists():
|
|
raise serializers.ValidationError(
|
|
{"error": "URL already exists for this workspace and owner"}
|
|
)
|
|
|
|
return super().update(instance, validated_data)
|
|
|
|
|
|
class IssueRecentVisitSerializer(serializers.ModelSerializer):
|
|
project_identifier = serializers.SerializerMethodField()
|
|
assignees = serializers.SerializerMethodField()
|
|
|
|
class Meta:
|
|
model = Issue
|
|
fields = [
|
|
"id",
|
|
"name",
|
|
"state",
|
|
"priority",
|
|
"assignees",
|
|
"type",
|
|
"sequence_id",
|
|
"project_id",
|
|
"project_identifier",
|
|
]
|
|
|
|
def get_project_identifier(self, obj):
|
|
project = obj.project
|
|
return project.identifier if project else None
|
|
|
|
def get_assignees(self, obj):
|
|
return list(
|
|
obj.assignees.filter(issue_assignee__deleted_at__isnull=True).values_list(
|
|
"id", flat=True
|
|
)
|
|
)
|
|
|
|
|
|
class ProjectRecentVisitSerializer(serializers.ModelSerializer):
|
|
project_members = serializers.SerializerMethodField()
|
|
|
|
class Meta:
|
|
model = Project
|
|
fields = ["id", "name", "logo_props", "project_members", "identifier"]
|
|
|
|
def get_project_members(self, obj):
|
|
members = ProjectMember.objects.filter(
|
|
project_id=obj.id, member__is_bot=False, is_active=True
|
|
).values_list("member", flat=True)
|
|
|
|
return members
|
|
|
|
|
|
class PageRecentVisitSerializer(serializers.ModelSerializer):
|
|
project_id = serializers.SerializerMethodField()
|
|
project_identifier = serializers.SerializerMethodField()
|
|
|
|
class Meta:
|
|
model = Page
|
|
fields = [
|
|
"id",
|
|
"name",
|
|
"logo_props",
|
|
"project_id",
|
|
"owned_by",
|
|
"project_identifier",
|
|
]
|
|
|
|
def get_project_id(self, obj):
|
|
return (
|
|
obj.project_id
|
|
if hasattr(obj, "project_id")
|
|
else obj.projects.values_list("id", flat=True).first()
|
|
)
|
|
|
|
def get_project_identifier(self, obj):
|
|
project = obj.projects.first()
|
|
|
|
return project.identifier if project else None
|
|
|
|
|
|
def get_entity_model_and_serializer(entity_type):
|
|
entity_map = {
|
|
"issue": (Issue, IssueRecentVisitSerializer),
|
|
"page": (Page, PageRecentVisitSerializer),
|
|
"project": (Project, ProjectRecentVisitSerializer),
|
|
}
|
|
return entity_map.get(entity_type, (None, None))
|
|
|
|
|
|
class WorkspaceRecentVisitSerializer(BaseSerializer):
|
|
entity_data = serializers.SerializerMethodField()
|
|
|
|
class Meta:
|
|
model = UserRecentVisit
|
|
fields = ["id", "entity_name", "entity_identifier", "entity_data", "visited_at"]
|
|
read_only_fields = ["workspace", "owner", "created_by", "updated_by"]
|
|
|
|
def get_entity_data(self, obj):
|
|
entity_name = obj.entity_name
|
|
entity_identifier = obj.entity_identifier
|
|
|
|
entity_model, entity_serializer = get_entity_model_and_serializer(entity_name)
|
|
|
|
if entity_model and entity_serializer:
|
|
try:
|
|
entity = entity_model.objects.get(pk=entity_identifier)
|
|
|
|
return entity_serializer(entity).data
|
|
except entity_model.DoesNotExist:
|
|
return None
|
|
return None
|
|
|
|
|
|
class WorkspaceHomePreferenceSerializer(BaseSerializer):
|
|
class Meta:
|
|
model = WorkspaceHomePreference
|
|
fields = ["key", "is_enabled", "sort_order"]
|
|
read_only_fields = ["workspace", "created_by", "updated_by"]
|
|
|
|
|
|
class StickySerializer(BaseSerializer):
|
|
class Meta:
|
|
model = Sticky
|
|
fields = "__all__"
|
|
read_only_fields = ["workspace", "owner"]
|
|
extra_kwargs = {"name": {"required": False}}
|
|
|
|
def validate(self, data):
|
|
# Validate description content for security
|
|
if "description" in data and data["description"]:
|
|
is_valid, error_msg = validate_json_content(data["description"])
|
|
if not is_valid:
|
|
raise serializers.ValidationError({"description": error_msg})
|
|
|
|
if "description_html" in data and data["description_html"]:
|
|
is_valid, error_msg = validate_html_content(data["description_html"])
|
|
if not is_valid:
|
|
raise serializers.ValidationError({"description_html": error_msg})
|
|
|
|
if "description_binary" in data and data["description_binary"]:
|
|
is_valid, error_msg = validate_binary_data(data["description_binary"])
|
|
if not is_valid:
|
|
raise serializers.ValidationError({"description_binary": error_msg})
|
|
|
|
return data
|
|
|
|
|
|
class WorkspaceUserPreferenceSerializer(BaseSerializer):
|
|
class Meta:
|
|
model = WorkspaceUserPreference
|
|
fields = ["key", "is_pinned", "sort_order"]
|
|
read_only_fields = ["workspace", "created_by", "updated_by"]
|