binarybeach/bb-plane-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[WEB-1691] fix: update ControlLink default target to _blank to avoid unwanted N-progress trigger. (#4927)

Browse source
This commit is contained in:
Prateek Shourya 2024-06-25 12:32:51 +05:30 • committed by GitHub
parent 0ce17ff212
commit 981a8e93ba
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 5 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

1
web/core/components/issues/issue-layouts/calendar/issue-block.tsx
View file

@ -71,7 +71,6 @@ export const CalendarIssueBlock = observer(
<ControlLink
id={`issue-${issue.id}`}
href={`/${workspaceSlug?.toString()}/projects/${projectId?.toString()}/issues/${issue.id}`}
target="_blank"
onClick={() => handleIssuePeekOverview(issue)}
className="block w-full text-sm text-custom-text-100 rounded border-b md:border-[1px] border-custom-border-200 hover:border-custom-border-400"
disabled={!!issue?.tempId || isMobile}

1
web/core/components/issues/issue-layouts/gantt/blocks.tsx
View file

@ -99,7 +99,6 @@ export const IssueGanttSidebarBlock: React.FC<Props> = observer((props) => {
return (
<ControlLink
href={`/${workspaceSlug}/projects/${issueDetails?.project_id}/issues/${issueDetails?.id}`}
target="_blank"
onClick={handleIssuePeekOverview}
className="line-clamp-1 w-full cursor-pointer text-sm text-custom-text-100"
disabled={!!issueDetails?.tempId}

1
web/core/components/issues/issue-layouts/kanban/block.tsx
View file

@ -217,7 +217,6 @@ export const KanbanIssueBlock: React.FC<IssueBlockProps> = observer((props) => {
{ "border border-custom-primary-70 hover:border-custom-primary-70": getIsIssuePeeked(issue.id) },
{ "bg-custom-background-80 z-[100]": isCurrentBlockDragging }
)}
target="_blank"
onClick={() => handleIssuePeekOverview(issue)}
disabled={!!issue?.tempId || isMobile}
>

3
web/core/components/issues/issue-layouts/list/block.tsx
View file

@ -229,8 +229,7 @@ export const IssueBlock = observer((props: IssueBlockProps) => {
id={`issue-${issue.id}`}
href={`/${workspaceSlug}/projects/${issue.project_id}/${issue.archived_at ? "archives/" : ""}issues/${
issue.id
}`}
target="_blank"
}`}
onClick={() => handleIssuePeekOverview(issue)}
className="w-full truncate cursor-pointer text-sm text-custom-text-100"
disabled={!!issue?.tempId}

1
web/core/components/issues/issue-layouts/spreadsheet/issue-row.tsx
View file

@ -242,7 +242,6 @@ const IssueRowDetails = observer((props: IssueRowDetailsProps) => {
>
<ControlLink
href={`/${workspaceSlug}/projects/${issueDetail.project_id}/issues/${issueId}`}
target="_blank"
onClick={() => handleIssuePeekOverview(issueDetail)}
className={cn(
"group clickable cursor-pointer h-11 w-[28rem] flex items-center text-sm after:absolute border-r-[0.5px] z-10 border-custom-border-200 bg-transparent group-[.selected-issue-row]:bg-custom-primary-100/5 group-[.selected-issue-row]:hover:bg-custom-primary-100/10",

1
web/core/components/issues/sub-issues/issue-list-item.tsx
View file

@ -131,7 +131,6 @@ export const IssueListItem: React.FC<ISubIssues> = observer((props) => {
<ControlLink
id={`issue-${issue.id}`}
href={`/${workspaceSlug}/projects/${issue.project_id}/issues/${issue.id}`}
target="_blank"
onClick={() => handleIssuePeekOverview(issue)}
className="w-full line-clamp-1 cursor-pointer text-sm text-custom-text-100"
>